Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix foreman service test #14598

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[6.15.z] Fix foreman service test #14598

merged 1 commit into from
Apr 3, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14583

Problem Statement

After turning off the foreman service, the check-tftp-storage requires the user to input the admin password since the foreman service isn't running. This causes the command to time out while waiting for input.

Solution

Let's whitelist the tftp storage check since it's not necessary for the test.

Related Issues

@Griffin-Sullivan @web-flow
Fix foreman service test (#14583)
963181e 
(cherry picked from commit 932b588)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 3, 2024 07:54
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 3, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/maintain/test_service.py::test_positive_foreman_service

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 3, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6280
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/maintain/test_service.py::test_positive_foreman_service --external-logging
Test Result : ================== 1 passed, 4 warnings in 1745.75s (0:29:05) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 3, 2024
@Satellite-QE Satellite-QE merged commit bfa30ce into 6.15.z Apr 3, 2024
16 of 17 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-932b588adffc0e8017c81124782b51667d5a06d1 branch April 3, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @Griffin-Sullivan